Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable app deploy e2e and address issue #2930

Closed
richard-cox opened this issue Aug 30, 2018 · 1 comment
Closed

Re-enable app deploy e2e and address issue #2930

richard-cox opened this issue Aug 30, 2018 · 1 comment
Assignees

Comments

@richard-cox
Copy link
Contributor

  • Consistently errors with test timeout Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
  • Test timeout is large already, there is most probably an underlying issue
  • Logging shows the following line is the cause deployApp.stepper.waitUntilCanNext('Go to App Summary');
  • There's most probably an error on screen that means the app does not successfully get created
  • Previously this was due to old test artificats. However test cf is clean and test with same secrets.yaml passes fine locally
  • We should look at this again once Deploy App Manifest overrides #2924 and e2e screenshot work has been completed
@richard-cox richard-cox self-assigned this Aug 30, 2018
KlapTrap added a commit that referenced this issue Aug 31, 2018
* v2-master: (149 commits)
  Test bump [e2e]
  Enable app deply e2e test
  Fix application deploy For request params ensure xGUID -> xGuid
  Temporarily disable app deploy test - see #2930
  Add additional logging
  Fix jetstream output
  Updates following review
  Fix README buttons after merge
  Fix code cov button
  Fix CF Console client [e2e]
  Check in travis E2E config for jetstream [e2e]
  Update package.json [e2e]
  Update docker-compose & Travis e2e script [e2e]
  Increase mem for standard `build`
  Enabled secure cookie for VCapApplication apps
  Pin dependency to new version of sqlitestore - cookie fix
  Update cache-control values - Static files served via backed (AIO + cf push world) should have `cache-control: no-cache` - IE caches some https content, therefore jetstream shouldn't cache any requests `cache-control: no-store`
  Weekly update
  Harden the service wall instance card - Ensure we only show the template, which requires serviceInstanceEntity, when we have it - Removed ServicesWallService provider, it's not used (ctor never called) - Removed/Sorted imports
  Ensure golint is installed
  ...
@richard-cox
Copy link
Contributor Author

Fixed via #2931

KlapTrap added a commit that referenced this issue Aug 31, 2018
* v2-master: (91 commits)
  This week;s updates
  Update following review
  Remove fdescribe
  Fix broken e2e tests [e2e]
  Don't need AWS CLI
  Test bump [e2e]
  Enable app deply e2e test
  Fix application deploy For request params ensure xGUID -> xGuid
  Reinstate all tests
  Run through with tests
  Final fix.
  Test
  Last time
  Debug
  Debug
  Bug fix
  Speed up test report debug
  Set insecure flag
  Temporarily disable app deploy test - see #2930
  Use minio client
  ...
KlapTrap added a commit that referenced this issue Aug 31, 2018
* v2-master: (95 commits)
  This week;s updates
  Update following review
  Remove fdescribe
  Fix broken e2e tests [e2e]
  Don't need AWS CLI
  Test bump [e2e]
  Enable app deply e2e test
  Fix application deploy For request params ensure xGUID -> xGuid
  Reinstate all tests
  Run through with tests
  Final fix.
  Test
  Last time
  Debug
  Debug
  Bug fix
  Speed up test report debug
  Set insecure flag
  Temporarily disable app deploy test - see #2930
  Use minio client
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant