Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depoy app via git url #1208

Merged
merged 3 commits into from
Aug 30, 2017
Merged

Depoy app via git url #1208

merged 3 commits into from
Aug 30, 2017

Conversation

richard-cox
Copy link
Contributor

@richard-cox richard-cox commented Aug 2, 2017 •
edited
Loading

Depends on #1202

@richard-cox
Copy link
Contributor Author

(1) UX: Deploy App: from arbitrary (public) Git URL (i.e. non-Github)

@richard-cox richard-cox mentioned this pull request Aug 3, 2017
Closed
@richard-cox
Feature complete
96ccfaa 
- Added backend for girurl source
- backend now tries to clone using branch
- Frontend now..
-- mandates https git url (ssh unsupported by back end)
-- request public url (private ssh keys/creds etc not supported)
-- branch is now mandatory and defaults to master
@richard-cox
Copy link
Contributor Author

(1) Backend: Deploy App: from arbitrary (public) Git URL (i.e. non-Github)

@richard-cox richard-cox changed the base branch from deploy-sources to master August 17, 2017 14:03
nwmac
nwmac approved these changes Aug 30, 2017
View reviewed changes
Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 97e9e3f into master Aug 30, 2017
@irfanhabib irfanhabib deleted the deploy-sources-git-url branch November 22, 2017 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nwmac nwmac nwmac approved these changes

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richard-cox @nwmac