Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stepper form visual fixes #1604

Merged
merged 6 commits into from
Feb 15, 2018
Merged

Stepper form visual fixes #1604

merged 6 commits into from
Feb 15, 2018

Conversation

richard-cox
Copy link
Contributor

@richard-cox richard-cox commented Feb 9, 2018

Fix two issues

#1584

  • Stepper form styles were bleeding into list styles.
  • Ensure top level styles stick to stepper level forms
  • In the future this should be encapsulated in a form component

#1589

  • Ensure we have a standard way of presenting and spacing the form inputs
  • Previously a mat-select in a mat-form-field would double up its margin

- Selecting cf/org/spaces in filter or add/deploy app should work again
- Only have one type of Space/Org Schema
…forms

- In the future these should be wrapped in their own component
@richard-cox richard-cox self-assigned this Feb 9, 2018
@cfdreddbot
Copy link

Hey richard-cox!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@richard-cox richard-cox changed the base branch from v2-master to fix-org-space-schemas February 9, 2018 17:32
@richard-cox richard-cox changed the base branch from fix-org-space-schemas to v2-master February 14, 2018 12:08
@KlapTrap KlapTrap self-assigned this Feb 15, 2018
@KlapTrap KlapTrap merged commit c585dec into v2-master Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants