Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hard coded copyright with Variable referenced Copyright for C… #1734

Merged

Conversation

jnpacker
Copy link

@jnpacker jnpacker commented Mar 9, 2018

…ompany name.

Signed-by: Joshua Packer jpacker@ca.ibm.com

There were some hard coded statements in the English and French json files. I re-used an existing Copy variable reference from the footer in the same json file.

Description

Dynamically generate the Copyright

Motivation and Context

This further extends the os-branding work.

How Has This Been Tested?

Rebuild the UI container to validate the output.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Docs update
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have followed the guidelines in CONTRIBUTING.md, including the required formatting of the commit message

…ompany name.

Signed-by: Joshua Packer jpacker@ca.ibm.com
@cfdreddbot
Copy link

Hey jnpacker!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@richard-cox richard-cox added the V1 label Mar 12, 2018
@richard-cox
Copy link
Contributor

@jnpacker Looks good. However we've just recently added the zh_CN locale and that will need updating too.

@richard-cox richard-cox self-requested a review March 13, 2018 17:54
Joshua Packer added 2 commits March 20, 2018 13:26
@jnpacker
Copy link
Author

jnpacker commented Mar 20, 2018

@richard-cox Was off the grid for a few. Updated the additional common file.

@richard-cox richard-cox merged commit e86f8f1 into cloudfoundry:master Mar 21, 2018
@richard-cox richard-cox removed the needs attention This PR needs attention label Mar 21, 2018
@richard-cox
Copy link
Contributor

@jnpacker Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants