Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users tables: Only show org/space name in pills when needed #2443

Merged
merged 2 commits into from
Jun 20, 2018

Conversation

richard-cox
Copy link
Contributor

  • Only show org name when there are multiple orgs (cf level)
  • Only show space name when there's multiple spaces (cf + org level)

@cfdreddbot
Copy link

Hey richard-cox!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@richard-cox richard-cox self-assigned this Jun 20, 2018
@codecov
Copy link

codecov bot commented Jun 20, 2018

Codecov Report

Merging #2443 into v2-master will not change coverage.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##           v2-master    #2443   +/-   ##
==========================================
  Coverage      70.81%   70.81%           
==========================================
  Files            589      589           
  Lines          24760    24760           
  Branches        5578     5581    +3     
==========================================
  Hits           17534    17534           
  Misses          7226     7226

Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nwmac nwmac merged commit 694ca48 into v2-master Jun 20, 2018
@nwmac nwmac deleted the only-show-org-space-when-needed branch June 20, 2018 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants