Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout on summary pages #2482

Merged
merged 1 commit into from
Jun 21, 2018
Merged

Fix layout on summary pages #2482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...res/cloud-foundry/tabs/cloud-foundry-summary-tab/cloud-foundry-summary-tab.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
.summary {
display: flex;
height: 100%;
min-height: 100%;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the current layout - the last card - the recent apps is supposed to size to the remaining space - with this change, this is no longer the case.

Copy link
Contributor Author

@KlapTrap KlapTrap Jun 21, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are we trying to achieve by having the recent apps shrink to fit the remaining size rather than being it's natural height?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intent was that the remaining space would be used for the apps list - so the more height there was, the more of the list that would be visible, rather than fixing some arbitrary height.

See: #2483 for a fix which I think keeps this behaviour but avoid the overlap issue.

width: 100%;
}