Fix create app step 'valid' which disabled stepper next in production #2566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richard-cox
commented
Jun 28, 2018
richard-cox
commented
- In production the statusChanges emits before we watch it for the result
- when we start watching it doesn't emit the now valid form state
- only seen in production when navigating to stepper, not when loading stepper
- fixes CF/Org/Space selector widget with 1 org and 1 space - user can not proceed #2467
- In production the statusChanges emits before we watch it for the result - when we start watching it doesn't emit the now valid form state - only seen in production when navigating to stepper, not when loading stepper
|
Hey richard-cox! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #2566 +/- ##
=============================================
+ Coverage 70.42% 70.44% +0.02%
=============================================
Files 594 594
Lines 25135 25139 +4
Branches 5675 5676 +1
=============================================
+ Hits 17701 17709 +8
+ Misses 7434 7430 -4 |
- We've got the `valid` pattern wrong in the steppers, the steps are child components and change the state of their parent components - Added this workaround, but we should think about changing this pattern (not sure how though, given that each step controls it's own valid state) - Have also tested other steppers for the same issue and this looks like the only one
|
@nwmac I've updated to fix the ExpressionChangedAfterItHasBeenCheckedError issues, however needs a re-review |
|
@richard-cox Feels like a hack to use setTimeout |
…edError" This reverts commit 18a384d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.