Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow connections: Loading indicator for lazy loaded pages #2615

Merged
merged 5 commits into from
Jul 4, 2018

Conversation

KlapTrap
Copy link
Contributor

@KlapTrap KlapTrap commented Jul 3, 2018

Fixes #2603

@KlapTrap KlapTrap self-assigned this Jul 3, 2018
@cfdreddbot
Copy link

Hey KlapTrap!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@codecov
Copy link

codecov bot commented Jul 3, 2018

Codecov Report

Merging #2615 into v2-master will decrease coverage by 0.04%.
The diff coverage is 48%.

@@              Coverage Diff              @@
##           v2-master    #2615      +/-   ##
=============================================
- Coverage      70.02%   69.98%   -0.05%     
=============================================
  Files            595      596       +1     
  Lines          25215    25267      +52     
  Branches        5694     5709      +15     
=============================================
+ Hits           17657    17683      +26     
- Misses          7558     7584      +26

Copy link
Contributor

@nwmac nwmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested looks good.

@nwmac nwmac merged commit 81065ed into v2-master Jul 4, 2018
@nwmac nwmac deleted the loading-indicator branch July 4, 2018 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants