Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix App Chips not collapsing long lists #2673

Merged
merged 3 commits into from
Jul 17, 2018
Merged

Conversation

irfanhabib
Copy link
Contributor

Fixes #2461

Switching <a> to a proper <button> fixes the issue of click handler not registering if content expansion causes a scroll bar to appear.

@cfdreddbot
Copy link

Hey irfanhabib!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@irfanhabib irfanhabib changed the title Fix App Chips not collapsing with long lists Fix App Chips not collapsing long lists Jul 16, 2018
@codecov
Copy link

codecov bot commented Jul 16, 2018

Codecov Report

Merging #2673 into v2-master will decrease coverage by 0.06%.
The diff coverage is 47.24%.

@@              Coverage Diff              @@
##           v2-master    #2673      +/-   ##
=============================================
- Coverage      47.95%   47.88%   -0.07%     
=============================================
  Files            597      597              
  Lines          25340    25396      +56     
  Branches        5735     5750      +15     
=============================================
+ Hits           12151    12161      +10     
- Misses         13189    13235      +46

@KlapTrap KlapTrap self-requested a review July 17, 2018 07:24
@KlapTrap KlapTrap merged commit ba9c17c into v2-master Jul 17, 2018
@nwmac nwmac deleted the fix-click-handler branch June 12, 2019 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not collapse security group tag list when there are lots of them
3 participants