-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature json schema #3050
Feature json schema #3050
Conversation
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
Signed-off-by: Hamza Hamidi <hamza.hamidi@orange.com>
- Improve typing - Move common components into new `shema-form` component - Allow users to toggle between form and text input whilst maintaining common value - Step valid state bound to type of input (form valid vs valid json) - Updated form errors to be more material like - Fixed stepper navigation (would 're-enter' last step on pressing 'next' in last step
Feature json schema
Hey richard-cox! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3050 +/- ##
============================================
- Coverage 70.89% 70.79% -0.1%
============================================
Files 641 642 +1
Lines 28174 28303 +129
Branches 6405 6437 +32
============================================
+ Hits 19973 20038 +65
- Misses 8201 8265 +64 |
- Also minor tidy of json form validate
To test, update line 169 in
|
# Conflicts: # src/frontend/app/shared/components/add-service-instance/add-service-instance/add-service-instance.component.spec.ts # src/frontend/app/shared/components/add-service-instance/add-service-instance/add-service-instance.component.ts # src/frontend/app/shared/shared.module.ts
…d of both form & json options)
Updates to original PR - See #2664
schema-form
component