Fix unit tests #3466
Merged
Fix unit tests #3466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richard-cox
commented
Apr 4, 2019
richard-cox
commented
- not sure how these are broken on master, all PRs have been passing
- fix is to ensure endpoint & home page component tests use pre-populated store
- also improved typing
- not sure how these are broken on master, all PRs have been passing - fix is to ensure endpoint & home page component tests use pre-populated store - also improved typing
|
✅ Hey richard-cox! The commit authors and yourself have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3466 +/- ##
============================================
+ Coverage 51.59% 51.6% +0.01%
============================================
Files 698 698
Lines 19465 19465
Branches 3447 3447
============================================
+ Hits 10042 10045 +3
+ Misses 9423 9420 -3 |
KlapTrap
pushed a commit
that referenced
this pull request
Apr 18, 2019
* v2-master: (41 commits) Tweaks following project update (#3476) Update status_updates.md Fix unit tests don't show the favourite list line seperator on the last set of entities Only show the filter toggle if there's something to filter on Add angular sanitizer to marked renderer Bump marked dependency to fix snyk error Address review comments Fix Gitlab deploy step (#3469) Update status_updates.md Fix after merge fix e2e test Fix unit tests (#3466) Fix unit tests - not sure how these are broken on master, all PRs have been passing - fix is to ensure endpoint & home page component tests use pre-populated store - also improved typing Removed fdescribe Fix e2e tests Tidy up types file Add specific help text to deploy step Add specific deploy types in base tile selector Ensure you can't press cancel on endpoint connect dialog while it's busy ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.