Entity catalogue: Service Instance Wall Fix #1 #3670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ity-catalogue-store-service-wall-2
|
✅ Hey richard-cox! The commit authors and yourself have already signed the CLA. |
KlapTrap
reviewed
Jul 3, 2019
| @@ -56,6 +57,8 @@ export class StratosBaseCatalogueEntity<T extends IEntityMetadata = IEntityMetad | |||
| * If no schemaKey is provided then the default schema will be returned | |||
| */ | |||
| public getSchema(schemaKey?: string) { | |||
| // TODO: schemaKey - ensure wherever this is called it contains the correct schemaKey (with respect to any config | |||
| // EntityCatalogueEntityConfig that may use a schemeKey different than that provided by entityCatalogue.getEntity's) | |||
There was a problem hiding this comment.
We need to run through usages and check that the correct schemaKey is used. Think is most cases this should come from an EntityCatalogueEntityConfig object (whether the schema key is populated or not). We then need to ensure that this has the correct schema key when different from the default one (for service instances schemas with/without space, everything related to this issue is marked with a // TODO: schemaKey).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
// TODO: schemaKeyserviceInstancesWithspaceEntityTypetypo