Fix setup detection for local users #3888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Hey nwmac! The commit authors and yourself have already signed the CLA. |
Codecov Report
@@ Coverage Diff @@
## v2-master #3888 +/- ##
=============================================
+ Coverage 52.22% 52.22% +<.01%
=============================================
Files 785 785
Lines 23010 23010
Branches 4124 4124
=============================================
+ Hits 12016 12017 +1
+ Misses 10994 10993 -1 |
richard-cox
suggested changes
Sep 20, 2019
There was a problem hiding this comment.
Code looks good and can now correctly log in, however i get an error when viewing the user profile
UAA_ENDPOINT=
AUTH_ENDPOINT_TYPE=local
LOCAL_USER=lu
LOCAL_USER_PASSWORD=lup
LOCAL_USER_SCOPE=stratos.admin
DEBU[Fri Sep 20 09:34:44 BST 2019] sessionCleanupMiddleware
DEBU[Fri Sep 20 09:34:44 BST 2019] errorLoggingMiddleware
DEBU[Fri Sep 20 09:34:44 BST 2019] urlCheckMiddleware
DEBU[Fri Sep 20 09:34:44 BST 2019] sessionMiddleware
DEBU[Fri Sep 20 09:34:44 BST 2019] getSessionValue
DEBU[Fri Sep 20 09:34:44 BST 2019] getSession
DEBU[Fri Sep 20 09:34:44 BST 2019] xsrfMiddleware
DEBU[Fri Sep 20 09:34:44 BST 2019] uaa request
DEBU[Fri Sep 20 09:34:44 BST 2019] GetSessionInt64Value
DEBU[Fri Sep 20 09:34:44 BST 2019] getSessionValue
DEBU[Fri Sep 20 09:34:44 BST 2019] getSession
DEBU[Fri Sep 20 09:34:44 BST 2019] GetSessionStringValue
DEBU[Fri Sep 20 09:34:44 BST 2019] getSessionValue
DEBU[Fri Sep 20 09:34:44 BST 2019] getSession
DEBU[Fri Sep 20 09:34:44 BST 2019] GetUAATokenRecord
DEBU[Fri Sep 20 09:34:44 BST 2019] NewPgsqlTokenRepository
DEBU[Fri Sep 20 09:34:44 BST 2019] FindAuthToken
DEBU[Fri Sep 20 09:34:44 BST 2019] Unable to Find UAA token: sql: no rows in result set
ERRO[Fri Sep 20 09:34:44 BST 2019] Database error finding UAA token: Unable to Find UAA token: sql: no rows in result set
{"time":"2019-09-20T09:34:44.452442325+01:00","level":"ERROR","prefix":"echo","file":"main.go","line":"953","message":"Unable to Find UAA token: sql: no rows in result set"}
Request: [2019-09-20T09:34:44+01:00] Remote-IP:"127.0.0.1" Method:"GET" Path:"/pp/v1/uaa/Users/fe9067e2-e224-43c0-acef-6a57d08cbbc7" Status:500 Latency:589.769µs Bytes-In:0 Bytes-Out:21
richard-cox
added
needs attention
richard-cox
approved these changes
Sep 20, 2019
KlapTrap
pushed a commit
that referenced
this pull request
Sep 25, 2019
* v3-master: Fix cf summary unit test failures - cf now has dependency on autoscaler - see #3916 catalogue: fixed initial state that was overwritten Travis: Build once and share build in e2e tests (#3901) Improve user clean up Ensure MB is only shown for memory based quota values in edit quota forms (#3892) Fix domains in create app shell stepper Fix git commit world WIP Fix two actionBuilder params issues - Fix three places where `includeRelations` were passed incorrectly to actionBuilder - Fix bind service Ensure multi endpoint requests only go out to connected/unconnectable endpoints - Fixes #3887 Travis: Build once and share build in e2e tests (#3901) Improve user clean up Ensure MB is only shown for memory based quota values in edit quota forms (#3892) Add support for view and edit profile for local user (#3883) Add fix to wait until delete indicator has been removed (#3889) FIx setup detection for local users (#3888) Ensure stepper buttons are always visible and content scrolls (#3890) E2E Test should run as user not admin (#3894)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup detection does not consider local user auth config - so if UAA_ENDPOINT is not set, you will see the setup screen, even if you have configured local user auth.