-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blitz - Add table view to marketplace service table #4064
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
richard-cox
commented
Dec 12, 2019
•
edited
Loading
edited
- UX needs review (number of columns in table)
- fixes Enable tile / list toggle for Marketplace view #4021
- `firehose_value_metric_rep_unhealthy_cell` deprecated, now use `firehose_value_metric_rep_garden_health_check_failed` - Try new metric first and fall back on old
- affects db migration of console config table to new config table - fixes #4013
Release 2.6.1 Release Notes and Version bump
* Fixes ingress and kube 1.16 version issue * Update Changelog * More test * Fix ingress tests
Mention STRATOS_BP_DEBUG to troubleshoot staging (v2-master)
…ong-running-service-actions
- sometimes these are fetched inline which aren't sorted
- Some brokers take a long time to execute create, update and delete service instance operations - This time exceeded the amount allowed by browser/jetstream - We now provide a custom response to the front end when this happens - Front end then handles this and also shows a custom error message
Backend changes to support long-running requests
…' into merge-v2-master
- Use a common way to get a service name, service link, broker name - Split out cf specific long running functionality - Show service as a link in app service instance card - Show service plan and broker in app service instance card - Update the service instance entity on Update as well as Delete (will show a better 'last operation' value)
…' into merge-v2-master
- Show mini error message, as per create, when updating service instance - Handle all 5XX status codes as errors - Update messages to reflect varience of error states - Show single popover message on error dismiss all button - Correct error page selector
… into merge-v2-master
) * Show more service instance last operation details * Show service instance service broker * Handle last operation & broker in table view * Show the service broker name in the service list service card * Fix create service instance from service instance page * Fix unit tests * Fix failing e2e test
d9e2fb2
to
5ae7fb6
Compare
…' into blitz-services-table
Codecov Report
@@ Coverage Diff @@
## master #4064 +/- ##
==========================================
+ Coverage 61.46% 61.57% +0.11%
==========================================
Files 872 884 +12
Lines 29460 29691 +231
Branches 4344 4368 +24
==========================================
+ Hits 18108 18283 +175
- Misses 11352 11408 +56 |
nwmac
approved these changes
Jan 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.