Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing feature flag descriptions #4195

Merged
merged 2 commits into from
Mar 31, 2020
Merged

Add missing feature flag descriptions #4195

merged 2 commits into from
Mar 31, 2020

Conversation

nwmac
Copy link
Contributor

@nwmac nwmac commented Mar 30, 2020

Fixes #4188

This PR:

  • Adds descriptions for missing feature flags
  • Uses a link to the CF docs if a feature flag does not have a description

@nwmac nwmac self-assigned this Mar 30, 2020
richard-cox
richard-cox approved these changes Mar 31, 2020
View reviewed changes
src/frontend/packages/cloud-foundry/src/shared/components/components.module.ts
@@ -283,7 +285,8 @@ const cfListCards: Type<CardCell<any>>[] = [
EventMetadataComponent,
...cfListTableCells,
...cfListCards,
ServiceInstanceLastOpComponent
ServiceInstanceLastOpComponent,
TableCellFeatureFlagDescriptionComponent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a biggy, table cells should go in cfListCards above, this helps tests.

@richard-cox richard-cox merged commit b69f7cc into master Mar 31, 2020
@richard-cox richard-cox deleted the feature-flags branch March 31, 2020 16:18
@richard-cox richard-cox mentioned this pull request Apr 1, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richard-cox richard-cox richard-cox approved these changes

Assignees

@nwmac nwmac

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Feature Flags with new entries
2 participants
@nwmac @richard-cox