Fix issue where app wall list failed to filter spaces when in maxed state #4662

richard-cox · 2020-10-12T17:34:41Z

fixes Error filtering applications by org #4658
to reproduce, get list into maxed state, filter by org and then filter by space
filtering by space used an incorrectly parsed org value

this was due to working code now failing...

export enum QParamJoiners {
  in = ' IN ',
}

QParamJoiners[' IN ']

for example see https://www.typescriptlang.org/play?ts=3.8.3#code/KYOwrgtgBAou0G8BQUoEEoF4oHICGOSAvkgMYD2IAzgC5RUR4A2TG2+hF1dIeEwAeQBmbWPADaDZqwC6AbigB6RVABEaVWUpVyTYADom5AOYAKXv2FoAlEA
fix is to ensure we access this in a safer way

…tate - The following code now fails ``` export enum QParamJoiners { in = ' IN ', } ``` ``` QParamJoiners[' IN '] ``` - Ensure we access this safer

nwmac

LGTM

Fix issue where app wall list failed to filter spaces when in maxed s…

7a4b9c8

…tate - The following code now fails ``` export enum QParamJoiners { in = ' IN ', } ``` ``` QParamJoiners[' IN '] ``` - Ensure we access this safer

richard-cox added the ready for review label Oct 12, 2020

richard-cox self-assigned this Oct 12, 2020

richard-cox mentioned this pull request Oct 12, 2020

Error filtering applications by org #4658

Closed

nwmac approved these changes Oct 13, 2020

View reviewed changes

nwmac merged commit 884b9b6 into master Oct 13, 2020

richard-cox deleted the fix-dev-maxed-filter branch October 19, 2020 09:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix issue where app wall list failed to filter spaces when in maxed state #4662

Fix issue where app wall list failed to filter spaces when in maxed state #4662

richard-cox commented Oct 12, 2020 •

edited

Loading

nwmac left a comment

Fix issue where app wall list failed to filter spaces when in maxed state #4662

Fix issue where app wall list failed to filter spaces when in maxed state #4662

Conversation

richard-cox commented Oct 12, 2020 • edited Loading

nwmac left a comment

Choose a reason for hiding this comment

richard-cox commented Oct 12, 2020 •

edited

Loading