HSC-1032 - Allow user to cancel VCS OAuth step in add-app #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ongk
force-pushed
the
1032-make-next-cancellable
branch
from
71c5ead to
9837ec4
Compare
| @@ -19,8 +20,8 @@ | |||
| * @param {object} $q - angular $q service | |||
| * @param {GITHUB_ENDPOINTS} GITHUB_ENDPOINTS - the public Github Endpoints | |||
There was a problem hiding this comment.
@param for eventService?
|
LGTM with a nit on ngdoc. |
ongk
force-pushed
the
1032-make-next-cancellable
branch
from
9837ec4 to
5b62162
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the select source step, when the user clicks next, we open a new tab to do the OAuth flow. However, something might go wrong where we aren't able to detect the issue in the proxy (callback is not called). For example, if the user specifies and invalid Github client ID, this results in a 404 page in Github. In this case, we want the user to be able to cancel out instead of being stuck at that step.
Depends on: https://github.com/hpcloud/helion-ui-framework/pull/143
Added on top of: https://github.com/hpcloud/stratos-ui/pull/651