HSC-1072 - Unit tests: UI: Expand unit tests for add-pipline #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depends on https://github.com/hpcloud/helion-ui-framework/pull/145 - Fixed endpoints generic cluster actions menu when browser is shrunk - Endpoint gallery-cards now are the same width - App summary org and space names are now links to endpoints pages - Add app workflow now uses filtered service/org/space as defaults - Fixed sticky app wall filters, this looked like a regression
Conflicts: src/plugins/cloud-foundry/view/applications/list/list.module.js
* HSC-1075: Squash JS files into a single file * HSC-1075: Updated to also squish all HMTL template (partials) into one file that is loaded up-front * Added missing changes for the template compilation * Fix for all unit tests being broken
- Fixed visibility of 'no services' message when there are no valid services - Fixed exception when there are no apps in a service but apps in another - Fixed gap where application model hasApps was not being set when there were no services - Ensured list module 'ready' is always set - Handle failed promises, specifically failed http get of apps - Fixed localisation of an error message
HSC-1094: Minor improvements following walk through
1071 - Unit tests: UI: Expand unit tests for delete-app-workflow
nwmac
reviewed
Sep 21, 2016
| @@ -349,7 +370,7 @@ | |||
|
|
|||
| getPipelineDetailsData: function () { | |||
| var that = this; | |||
| var hceModel = this.modelManager.retrieve('cloud-foundry.model.hce'); | |||
| var hceModel = this.hceModel; | |||
There was a problem hiding this comment.
We seem to have a mix of using this.hceModel and also looking this up each time, i.e.
var hceModel = this.modelManager.retrieve('cloud-foundry.model.hce');
I assume this.hceModel is set in the code that adopts this prototype?
nwmac
reviewed
Sep 21, 2016
|
|
||
| page.open('http://localhost:9876/?id=59354468') | ||
|
|
||
| }(phantom)) |
There was a problem hiding this comment.
What's this file?? Should this be checked in? Folder is "karma-59354468" which seems odd.
+1 per Neil, this is ready to be merged.
HSC-683 Update docs, naming
1074 - Unit tests: UI: Expand unit tests for github code - Part I
1070 - Unit tests: UI: Expand unit tests for add-app-workflow directive
* '1074-II' of github.com:hpcloud/stratos-ui: Clean up # Conflicts: # src/plugins/github/model/model.module.spec.js
1074 - Unit tests: UI: Expand unit tests for github code - Part II
* '1072' of github.com:hpcloud/stratos-ui: More cleanup Clean-up 1072 - Unit tests: UI: Expand unit tests for add-pipline
|
Looks like this could do with re-basing on master |
wchrisjohnson
changed the title
|
Replacing this PR with: https://github.com/hpcloud/stratos-ui/pull/749 Therefore closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.hpcloud.net/browse/HSC-1072
code coverage = 93.9%