Fix Injection of 'aliasEntitiesEnabled' into IdentityProviderEndpoints #2943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have created an issue in Pivotal Tracker to manage this: https://www.pivotaltracker.com/story/show/187884312 The labels on this github issue will be updated when the story is started. |
strehle
approved these changes
Jul 8, 2024
adrianhoelzl-sap
deleted the
fix-injection-of-aliasentitiesenabled-into-idpendpoints
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During tests of the alias feature, we found out that the deletion of IdPs with an alias is always rejected, even when the
aliasEntitiesEnabledflag is set totrue. This is caused by the fact that the property is wrongly injected into theIdentityProviderEndpoints.