fix: test bug (SamlLoginIT) #2957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
peterhaochen47
commented
Jul 16, 2024
peterhaochen47
commented
- this test creates a real SAML provider (pointing to a running saml server: http://simplesamlphp.uaa-acceptance.cf-app.com/saml2/idp/metadata.php) and also a dummy SAML provider (pointing to a randomly generated saml idp metadata). Before this commit, the test is mistakenly performing SAML flow via the dummy provider only (which somehow works currently on this branch but is probably not what this test intends to do). This is because the two providers have identical login link texts (which are shown on the UAA login page) and the click action ends up clicking the wrong provider link text.
- this commit fixes the issue by differentiating the two providers by different login link text, so that the test is now performing SAML flow via the real IDP.
- this test creates a real SAML provider (pointing to a running saml server: http://simplesamlphp.uaa-acceptance.cf-app.com/saml2/idp/metadata.php) and also a dummy SAML provider (pointing to a randomly generated saml idp metadata). Before this commit, the test is mistakenly performing SAML flow via the dummy provider only (which somehow works currently on this branch but is probably not what this test intends to do). This is because the two providers have identical login link texts (which are shown on the UAA login page) and the click action ends up clicking the wrong provider link text. - this commit fixes the issue by differentiating the two providers by different login link text, so that the test is now performing SAML flow via the real IDP.
strehle
approved these changes
Jul 16, 2024
peterhaochen47
deleted the
pr/fix-saml-login-it-testSimpleSamlPhpLoginInTestZone1Works
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.