Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ErrorRoutingIT test #2977

Merged
merged 2 commits into from
Jul 23, 2024
Merged

fix: ErrorRoutingIT test #2977

merged 2 commits into from
Jul 23, 2024

Commits on Jul 23, 2024

  1. fix: ErrorRoutingIT test failure message 

    - correct the order of actual vs. expected, such that
the test failure message is correct
- before this commit, the failure message is:
```
java.lang.AssertionError: Check status code from /error429 is 200 expected:<429> but was:<200>
```
which is not correct
    @peterhaochen47
    peterhaochen47 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    de7aa70 View commit details
    Browse the repository at this point in the history

  2. fix: ErrorRoutingIT 

    - the test is intended to access /error429 as a browser would
and expects a 200 response (due to this request mapping:
https://github.com/cloudfoundry/uaa/blob/0a28b5c5aa33c68a5cdb20f23812d5187135b4a8/server/src/main/java/org/cloudfoundry/identity/uaa/home/HomeController.java#L155 and NOT https://github.com/cloudfoundry/uaa/blob/0a28b5c5aa33c68a5cdb20f23812d5187135b4a8/server/src/main/java/org/cloudfoundry/identity/uaa/home/HomeController.java#L144)

- however, in some environments where this test is run, the test
does not access the /error429 like a browser would (e.g. does not
have the request header "Accept: text/html" by default), so explictly
adding this header to the test setup to better emulate a browser
request
    @peterhaochen47
    peterhaochen47 committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    fd9f193 View commit details
    Browse the repository at this point in the history