Allow throwing things other than errors within withBrowser #146
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a super minor thing but sometimes for debugging I use the trick shown here (
throw new Error('leave the browser open')
) to leave the headed browser open even if the test passes. This is fine, but sometimes I want to type less, so I dothrow 0
which should have the same effect (makes the test fail so the browser says open). But there is a bug where Pleasantest expects anything thrown from the test to be an Error. This PR fixes that bug.