Node resolver: Refactor, add tests, and improve edge cases #159
Conversation
| @@ -0,0 +1,118 @@ | |||
| import type { Plugin, RollupCache } from 'rollup'; | |||
There was a problem hiding this comment.
Nothing in here has changed, it was just moved out of npm-plugin
| ./node_modules/foo/package.json {"main": "entry.js"} | ||
| ./node_modules/foo/entry.js | ||
| `); | ||
| expect(await fs.resolve('foo')).toBe('./node_modules/foo/entry.js'); |
There was a problem hiding this comment.
What I've done in the past for something like this is to make real files/folders for each test, but I like this better because it is easier to see the whole test in one place, and because changes are easier to make and will show up better in diffs, etc.
| test.todo('LOAD_PACKAGE_SELF'); | ||
| test.todo('LOAD_PACKAGE_IMPORTS'); |
There was a problem hiding this comment.
I left these tests out for now. Package imports are node's new way of creating "aliases" to files in your project, so you can do stuff like import "#utils instead of putting large relative paths. I didn't implement support for that yet. And package self refers to being able to import a package in itself (like how in this project we import "pleasantest" instead of import '../dist/...'). Support for that also isn't implemented yet.
Both are edge cases and I'll get to them eventually, or when someone asks for it
|
@calebeby I've started reviewing this, I'll finish reviewing it tomorrow. 🔍 👀 |
Closes #155
I went through https://nodejs.org/api/modules.html#modules_all_together, and tried to copy Node's commonJS resolution pretty closely.
Now the resolver is shared between the "extension resolver" and the "node modules resolver". Previously they did not share code, but since there is a lot of overlap, now they live in the same place and share code.
The "extension resolver" handles resolving
./asdfto./asdf.ts,./asdf/index.js, and reading./asdf/package.jsonand resolving through there if it exists.The "node modules resolver" handles resolving node_modules paths.