Fix regression with loadJS always throwing #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebeby
commented
Aug 18, 2021
| @@ -383,6 +383,7 @@ const createTab = async ({ | |||
| const res = await safeEvaluate( | |||
| loadJS, | |||
| `import(${JSON.stringify(url)}) | |||
| .then(mod => {}) | |||
There was a problem hiding this comment.
Here is why this works:
On line 396, that function checks res to see if it exists, it assumes that it is an error (that is how it works with runJS). If res exists, then it throws it.
In the case of loadJS, res is the module object that got imported. So I was seeing a confusing error that said Thrown: {}. The addition of this line fixes this bug because it discards the imported module so res is undefined. The catch block still works to make res exist if something was thrown.
gerardo-rodriguez
approved these changes
Aug 18, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what happens when I don't write a test for the core functionality and use
test.todo😬 🙈Regression introduced in #199