Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow functions to be passed to runJS #234

Merged
merged 3 commits into from
Sep 1, 2021

Conversation

gerardo-rodriguez
Copy link
Member

This feature was co-written with @calebeby. This allows functions to be passed to runJS.

See the new test to help understand the intent.

Closes #47

@calebeby
Copy link
Member

@gerardo-rodriguez Can you add a changeset?

Copy link
Contributor

@Paul-Hebert Paul-Hebert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice work! 🦖

(I started typing :tada and then the t-rex popped up, so you get a 🦖 instead)

@gerardo-rodriguez gerardo-rodriguez merged commit 2914882 into main Sep 1, 2021
@gerardo-rodriguez gerardo-rodriguez deleted the feature/pass-functions-to-runjs branch September 1, 2021 16:48
@github-actions github-actions bot mentioned this pull request Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There should be a way to pass functions into runJS
3 participants