Normalize whitespace in getAccessibilityTree #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebeby
requested review from
Paul-Hebert,
gerardo-rodriguez and
spaceninja
calebeby
commented
Dec 22, 2021
| @@ -58,24 +56,23 @@ test( | |||
| ↳ description: "extended description" | |||
| text "extended description" | |||
| `); | |||
| expect(await getAccessibilityTree(body, { includeText: true })) | |||
There was a problem hiding this comment.
Since we changed the default value of includeText to true, this snapshot and the one above are the same. I changed the includeText property here so we test both cases.
…normalize-whitespace
…sibilityTree-normalize-whitespace
…normalize-whitespace
…normalize-whitespace
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now anytime there is contiguous whitespace in text strings it is collapsed into a single space. This matches the behavior of browser accessibility trees.
This is a breaking change because it changes the
getAccessibilityTreeoutput, and may break your snapshots. Update your snapshots with Jest and review the changes.Since it is a breaking change I will hold off on merging it