Handle errors when browser launching fails #78
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug I noticed on cloudfour-patterns.
Previously, if npm failed to run the postinstall script for puppeteer (or ignored it? I noticed npm@7 ignores postinstall scripts sometimes), then when you run pleasantest, here is what would happen:
Now, errors that are thrown in the child process get passed to the main process, where they are thrown:
Testing
npm ci
rm -rf node_modules/puppeteer/.local-chromium
rm /Users/<your username>/Library/Application\ Support/pleasantest-nodejs/config.json
npm run test toBeVisible
. It should fail and display a helpful message.node ./node_modules/puppeteer/install.js
to re-download the browser binariesnpm run test
should pass