Refactorings of p2p crate
#150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of passing a mutable outbox to all sub-systems, have all sub-systems implement `Iterator`.
This was not used.
cloudhead
force-pushed
the
cloudhead/refactor-alternative
branch
from
dd6a3d6
to
07e234c
Compare
Instead of having each manager module have its own events, we use a single event namespace. This simplifies the client event mapper, which can be removed in a subsequent commit.
Instead of relying on the return value when receiving a `verack`, we rely on the `PeerNegotiated` event, internalizing more of the logic. In passing, we remove the `Socket` abstraction, which wasn't used.
Further reduce logic inside `fsm.rs`.
Since these are used in logs, they should be consistent with the other logs.
cloudhead
force-pushed
the
cloudhead/refactor-alternative
branch
from
07e234c
to
d7e958f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.