-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/upgrade clduploadwidget signed and captions #165
Feat/upgrade clduploadwidget signed and captions #165
Conversation
…idget-signed-and-captions
@max-programming is attempting to deploy a commit to the Cloudinary DevX Team on Vercel. A member of the Team first needs to authorize it. |
hey @max-programming this is looking good, push a few style/cleanup tweaks i think the only thing id like a little different is the app router Uploader component the recommendation that I've been using to get around the client components is to create a light wrapper around the component see example: https://next.cloudinary.dev/nextjs-14#app-router-app I think that would be preferable so that you can includ the result UI inside of the page file simlar to what you have in the pages directory wdyt? |
@colbyfayock The reason I did not create a wrapper component for both So I put them together inside one client component. |
@max-programming got it makes sense, could we then use the same <Uploader component in both examples then for consistency? currently its only used for the App Router |
@colbyfayock Done ✅ |
looks great, thanks @max-programming |
This pull request includes upgrading two examples