[azure/event_hubs] Set public_network_access_enabled to null when there are ip_rules or virtual_network_rules
#36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thwiv
approved these changes
May 1, 2024
missingcharacter
force-pushed
the
eventhub-selected-networks
branch
2 times, most recently
from
7fcac82
to
362c30f
Compare
… there are `ip_rule`s or `virtual_network_rule`s Only create `virtual_network_rule`s for subnets we will NOT create a private endpoint for
missingcharacter
force-pushed
the
eventhub-selected-networks
branch
from
362c30f
to
590c0dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.