Don't fail if some thread exit during attach. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paboldin
suggested changes
Mar 6, 2018
src/kpatch_ptrace.c
Outdated
| (void *)(uintptr_t)status); | ||
| if (ret < 0) { | ||
| kplogerror("can't cont tracee\n"); | ||
| return -1; | ||
| } | ||
| } while (1); | ||
|
|
||
| pctx = kpatch_ptrace_ctx_alloc(proc); |
There was a problem hiding this comment.
In case of failure here you leave the thread attached but unaccounted. Please fix restore the allocations before the attachment.
There was a problem hiding this comment.
Moved pctx allocation before SIGSTOP processing, but after successfull PTRACE_ATTACH.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thread creation during attach was correctly processed.
This commit adds processing of cases when some threads exit during attach without failing to patch. Threads are added to list only if they been correctly attached to.