fix: don't overload function names with vars

cloudnativelabs · Apr 14, 2021 · 0faf772 · 0faf772
1 parent 53cfbe3
commit 0faf772
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/pkg/controllers/routing/aws.go b/pkg/controllers/routing/aws.go
@@ -54,8 +54,8 @@ func (nrc *NetworkRoutingController) disableSourceDestinationCheck() {
 			},
 		)
 		if err != nil {
-			awserr := err.(awserr.Error)
-			if awserr.Code() == "UnauthorizedOperation" {
+			awsErr := err.(awserr.Error)
+			if awsErr.Code() == "UnauthorizedOperation" {
 				nrc.ec2IamAuthorized = false
 				klog.Errorf("Node does not have necessary IAM creds to modify instance attribute. So skipping disabling src-dst check.")
 				return

diff --git a/pkg/controllers/routing/bgp_policies.go b/pkg/controllers/routing/bgp_policies.go
@@ -130,13 +130,13 @@ func (nrc *NetworkRoutingController) addServiceVIPsDefinedSet() error {
 		}
 	}
 	for _, currentPrefix := range currentDefinedSet.Prefixes {
-		delete := true
+		shouldDelete := true
 		for _, prefix := range advIPPrefixList {
 			if currentPrefix.IpPrefix == prefix.IpPrefix {
-				delete = false
+				shouldDelete = false
 			}
 		}
-		if delete {
+		if shouldDelete {
 			toDelete = append(toDelete, currentPrefix)
 		}
 	}
@@ -216,13 +216,13 @@ func (nrc *NetworkRoutingController) addiBGPPeersDefinedSet() ([]string, error)
 		}
 	}
 	for _, currentPrefix := range currentDefinedSet.List {
-		delete := true
+		shouldDelete := true
 		for _, prefix := range iBGPPeerCIDRs {
 			if currentPrefix == prefix {
-				delete = false
+				shouldDelete = false
 			}
 		}
-		if delete {
+		if shouldDelete {
 			toDelete = append(toDelete, currentPrefix)
 		}
 	}
@@ -322,13 +322,13 @@ func (nrc *NetworkRoutingController) addAllBGPPeersDefinedSet(iBGPPeerCIDRs, ext
 		}
 	}
 	for _, currentPeer := range currentDefinedSet.List {
-		delete := true
+		shouldDelete := true
 		for _, peer := range allBgpPeers {
 			if peer == currentPeer {
-				delete = false
+				shouldDelete = false
 			}
 		}
-		if delete {
+		if shouldDelete {
 			toDelete = append(toDelete, currentPeer)
 		}
 	}