fix build break due to go linter errros

pkg/controllers/netpol/network_policy_controller.go

@@ -201,7 +201,7 @@ func (npc *NetworkPolicyController) ensureTopLevelChains() {
 		glog.Fatalf("Failed to initialize iptables executor due to %s", err.Error())
 	}
 
-	addUuidForRuleSpec := func(chain string, ruleSpec *[]string) (string, error) {
+	addUUIDForRuleSpec := func(chain string, ruleSpec *[]string) (string, error) {
 		hash := sha256.Sum256([]byte(chain + strings.Join(*ruleSpec, "")))
 		encoded := base32.StdEncoding.EncodeToString(hash[:])[:16]
 		for idx, part := range *ruleSpec {
@@ -236,7 +236,7 @@ func (npc *NetworkPolicyController) ensureTopLevelChains() {
 			if strings.HasPrefix(rule, "-P") || strings.HasPrefix(rule, "-N") {
 				// if this chain has a default policy, then it will show as rule #1 from iptablesCmdHandler.List so we
 				// need to account for this offset
-				ruleIndexOffset += 1
+				ruleIndexOffset++
 				continue
 			}
 			if strings.Contains(rule, uuid) {
@@ -265,39 +265,39 @@ func (npc *NetworkPolicyController) ensureTopLevelChains() {
 			glog.Fatalf("Failed to run iptables command to create %s chain due to %s", customChain, err.Error())
 		}
 		args := []string{"-m", "comment", "--comment", "kube-router netpol", "-j", customChain}
-		uuid, err := addUuidForRuleSpec(builtinChain, &args)
+		uuid, err := addUUIDForRuleSpec(builtinChain, &args)
 		if err != nil {
 			glog.Fatalf("Failed to get uuid for rule: %s", err.Error())
 		}
 		ensureRuleAtPosition(builtinChain, args, uuid, 1)
 	}
 
 	whitelistServiceVips := []string{"-m", "comment", "--comment", "allow traffic to cluster IP", "-d", npc.serviceClusterIPRange.String(), "-j", "RETURN"}
-	uuid, err := addUuidForRuleSpec(kubeInputChainName, &whitelistServiceVips)
+	uuid, err := addUUIDForRuleSpec(kubeInputChainName, &whitelistServiceVips)
 	if err != nil {
 		glog.Fatalf("Failed to get uuid for rule: %s", err.Error())
 	}
 	ensureRuleAtPosition(kubeInputChainName, whitelistServiceVips, uuid, 1)
 
 	whitelistTCPNodeports := []string{"-p", "tcp", "-m", "comment", "--comment", "allow LOCAL TCP traffic to node ports", "-m", "addrtype", "--dst-type", "LOCAL",
 		"-m", "multiport", "--dports", npc.serviceNodePortRange, "-j", "RETURN"}
-	uuid, err = addUuidForRuleSpec(kubeInputChainName, &whitelistTCPNodeports)
+	uuid, err = addUUIDForRuleSpec(kubeInputChainName, &whitelistTCPNodeports)
 	if err != nil {
 		glog.Fatalf("Failed to get uuid for rule: %s", err.Error())
 	}
 	ensureRuleAtPosition(kubeInputChainName, whitelistTCPNodeports, uuid, 2)
 
 	whitelistUDPNodeports := []string{"-p", "udp", "-m", "comment", "--comment", "allow LOCAL UDP traffic to node ports", "-m", "addrtype", "--dst-type", "LOCAL",
 		"-m", "multiport", "--dports", npc.serviceNodePortRange, "-j", "RETURN"}
-	uuid, err = addUuidForRuleSpec(kubeInputChainName, &whitelistUDPNodeports)
+	uuid, err = addUUIDForRuleSpec(kubeInputChainName, &whitelistUDPNodeports)
 	if err != nil {
 		glog.Fatalf("Failed to get uuid for rule: %s", err.Error())
 	}
 	ensureRuleAtPosition(kubeInputChainName, whitelistUDPNodeports, uuid, 3)
 
 	for externalIPIndex, externalIPRange := range npc.serviceExternalIPRanges {
 		whitelistServiceVips := []string{"-m", "comment", "--comment", "allow traffic to external IP range: " + externalIPRange.String(), "-d", externalIPRange.String(), "-j", "RETURN"}
-		uuid, err = addUuidForRuleSpec(kubeInputChainName, &whitelistServiceVips)
+		uuid, err = addUUIDForRuleSpec(kubeInputChainName, &whitelistServiceVips)
 		if err != nil {
 			glog.Fatalf("Failed to get uuid for rule: %s", err.Error())
 		}

pkg/controllers/netpol/network_policy_controller_test.go

@@ -2,7 +2,6 @@ package netpol
 
 import (
 	"context"
-	"github.com/cloudnativelabs/kube-router/pkg/options"
 	"net"
 	"strings"
 	"testing"
@@ -18,6 +17,8 @@ import (
 	"k8s.io/client-go/informers"
 	clientset "k8s.io/client-go/kubernetes"
 	"k8s.io/client-go/kubernetes/fake"
+
+	"github.com/cloudnativelabs/kube-router/pkg/options"
 )
 
 // newFakeInformersFromClient creates the different informers used in the uneventful network policy controller