[testing] run go linters (#943)

* run go linters for static code checking

* fix(lint): fix all goimports linting errors

* fix(lint): fix all golint errors

* fix(lint): fix all spelling errors

Co-authored-by: Aaron U'Ren <aauren@gmail.com>

.golangci.yml

@@ -1,2 +1,23 @@
 run:
   timeout: 5m
+linters:
+  disable-all: true
+  enable:
+    - deadcode
+    - errcheck
+    - gofmt
+    - goimports
+    - golint
+    - gosimple
+    - govet
+    - ineffassign
+    - misspell
+    - staticcheck
+    - structcheck
+    - typecheck
+    - unused
+    - varcheck
+output:
+  format: tab
+  print-issued-lines: true
+  print-linter-name: true

pkg/cmd/kube-router.go

@@ -17,11 +17,12 @@ import (
 	"github.com/cloudnativelabs/kube-router/pkg/options"
 	"github.com/golang/glog"
 
+	"time"
+
 	"k8s.io/client-go/informers"
 	"k8s.io/client-go/kubernetes"
 	"k8s.io/client-go/rest"
 	"k8s.io/client-go/tools/clientcmd"
-	"time"
 )
 
 // These get set at build time via -ldflags magic

pkg/controllers/netpol/namespace.go

@@ -1,10 +1,11 @@
 package netpol
 
 import (
+	"reflect"
+
 	"github.com/golang/glog"
 	api "k8s.io/api/core/v1"
 	"k8s.io/client-go/tools/cache"
-	"reflect"
 )
 
 func (npc *NetworkPolicyController) newNamespaceEventHandler() cache.ResourceEventHandler {

pkg/controllers/netpol/network_policy_controller_test.go

@@ -2,14 +2,15 @@ package netpol
 
 import (
 	"context"
-	netv1 "k8s.io/api/networking/v1"
-	"k8s.io/apimachinery/pkg/api/resource"
-	"k8s.io/client-go/tools/cache"
 	"net"
 	"strings"
 	"testing"
 	"time"
 
+	netv1 "k8s.io/api/networking/v1"
+	"k8s.io/apimachinery/pkg/api/resource"
+	"k8s.io/client-go/tools/cache"
+
 	v1 "k8s.io/api/core/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/labels"
@@ -146,15 +147,15 @@ func tCreateFakePods(t *testing.T, podInformer cache.SharedIndexInformer, nsInfo
 		{name: "nsC", labels: labels.Set{"name": "c"}},
 		{name: "nsD", labels: labels.Set{"name": "d"}},
 	}
-	ips_used := make(map[string]bool)
+	ipsUsed := make(map[string]bool)
 	for _, pod := range pods {
 		podNamespaceMap.addPod(pod)
 		ipaddr := "1.1." + pod.ip
-		if ips_used[ipaddr] {
+		if ipsUsed[ipaddr] {
 			t.Fatalf("there is another pod with the same Ip address %s as this pod %s namespace %s",
 				ipaddr, pod.name, pod.name)
 		}
-		ips_used[ipaddr] = true
+		ipsUsed[ipaddr] = true
 		tAddToInformerStore(t, podInformer,
 			&v1.Pod{ObjectMeta: metav1.ObjectMeta{Name: pod.name, Labels: pod.labels, Namespace: pod.namespace},
 				Status: v1.PodStatus{PodIP: ipaddr}})