Oops, i guess my unit test was flaky in #1068

cloudnativelabs · May 25, 2021 · c139c04 · c139c04
1 parent e49c255
commit c139c04
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/pkg/utils/ipset.go b/pkg/utils/ipset.go
@@ -447,7 +447,13 @@ func buildIPSetRestore(ipset *IPSet) string {
 		ipSetRestore.WriteString(fmt.Sprintf("flush %s\n", tmpSetName))
 	}
 
+	setsToDestroy := make([]string, 0, len(tmpSets))
 	for _, tmpSetName := range tmpSets {
+		setsToDestroy = append(setsToDestroy, tmpSetName)
+	}
+	// need to destroy the sets in a predictable order for unit test!
+	sort.Strings(setsToDestroy)
+	for _, tmpSetName := range setsToDestroy {
 		// finally, destroy the tmp sets.
 		ipSetRestore.WriteString(fmt.Sprintf("destroy %s\n", tmpSetName))
 	}