Merge pull request #975 from mrueg/conv-fix

Fix unnecessary conversions
cloudnativelabs · Aug 21, 2020 · c6ef3b8 · c6ef3b8
2 parents b7610a0 + 4d1fc8d
commit c6ef3b8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pkg/controllers/proxy/network_services_controller.go b/pkg/controllers/proxy/network_services_controller.go
@@ -722,7 +722,7 @@ func (nsc *NetworkServicesController) publishMetrics(serviceInfoMap serviceInfoM
 		endTime := time.Since(start)
 		glog.V(2).Infof("Publishing IPVS metrics took %v", endTime)
 		if nsc.MetricsEnabled {
-			metrics.ControllerIpvsMetricsExportTime.Observe(float64(endTime.Seconds()))
+			metrics.ControllerIpvsMetricsExportTime.Observe(endTime.Seconds())
 		}
 	}()
 

diff --git a/pkg/healthcheck/health_controller.go b/pkg/healthcheck/health_controller.go
@@ -110,7 +110,7 @@ func (hc *HealthController) HandleHeartbeat(beat *ControllerHeartbeat) {
 // CheckHealth evaluates the time since last heartbeat to decide if the controller is running or not
 func (hc *HealthController) CheckHealth() bool {
 	health := true
-	graceTime := time.Duration(1500 * time.Millisecond)
+	graceTime := time.Duration(1500) * time.Millisecond
 
 	if hc.Config.RunFirewall {
 		if time.Since(hc.Status.NetworkPolicyControllerAlive) > hc.Config.IPTablesSyncPeriod+hc.Status.NetworkPolicyControllerAliveTTL+graceTime {