support networkpolicy that egress to namedport without dst-peer #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fzu-huang Thanks for your PR. I have already taken care of #1035 in PR #1010 (https://github.com/cloudnativelabs/kube-router/blob/pod-fw-sync/pkg/controllers/netpol/pod.go#L43) Would you mind if you just address #1036 as part of this PR? |
fzu-huang
force-pushed
the
fzu-huang-patch
branch
from
dc2b8b9
to
12e58b5
Compare
|
@murali-reddy done. I'll edit this pr's title |
fzu-huang
changed the title
fzu-huang
changed the title
fzu-huang
force-pushed
the
fzu-huang-patch
branch
from
12e58b5
to
2f864e3
Compare
aauren
reviewed
Mar 18, 2021
aauren
approved these changes
Mar 18, 2021
aauren
reviewed
Mar 19, 2021
|
With the minor fix that I mentioned, I have done a manual end-to-end test in one of our clusters and have been able to see that this PR works successfully with named ports on egress policies without a host selector. |
fzu-huang
force-pushed
the
fzu-huang-patch
branch
from
2f864e3
to
411e3ec
Compare
aauren
approved these changes
Mar 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[deprecated]support pod's label changes : #1035
support networkpolicy that egress to namedport without dst-address: #1036