Add Route Sync Routine #1262
Merged
Add Route Sync Routine #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aauren
force-pushed
the
fix/route_sync_routine
branch
2 times, most recently
from
5173dbb to
beb279f
Compare
Added the following items to the original logic: * Added map route entry deletion on withdrawl so that the system doesn't incorrectly sync it back to the kernel's routing table * Added an immediate route sync upon BGP path receive * Added a mutex to ensure that deleted routes aren't accidentally synced back to the system * Added stopCh and wg (wait group) handling * Increase default sync time from 15 seconds to 1 minute since this scenario is unlikely and netlink calls could potentially be burdensome in large clusters.
aauren
force-pushed
the
fix/route_sync_routine
branch
from
beb279f to
b73f5f3
Compare
|
Gave this quite a bit of testing in my development cluster. Along with the unit tests, I think that there can be a reasonable amount of confidence. Merging. |
eskytthe
added a commit
to eskytthe/kube-router
that referenced
this pull request
Apr 29, 2022
eskytthe
added a commit
to eskytthe/kube-router
that referenced
this pull request
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@murali-reddy @mrueg
Replaces #1151 and largely based on the original commit @Rusox89 made in that PR. Thanks for your work there!
I just rebased his work and patched up some stuff to fix a few unaccounted use-cases and bring it a little more in line with the rest of the kube-router code base.
Fixes #509, which is a rare situation where routes will get lost after an interface is brought down and back up, by introducing a route synchronization goroutine. This keeps track of what the kernel routing table should look like and syncs it from time to time.
I have deployed this in a test cluster and tested taking routes in / out and starting / stopping peers. It acts correctly in all use-cases.