Prevent masquerading pod -> NodeIP traffic #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzub
force-pushed
the
173-pod-to-node-nonat
branch
from
a68ac08
to
51c173c
Compare
|
Appears to work well, and automatically deletes the problematic masquerading rule upon kube-router upgrade. Running e2e tests now. |
|
@bzub Why add go-ipset when utils/ipset do the same thing? |
bzub
force-pushed
the
173-pod-to-node-nonat
branch
from
51c173c
to
5d1197f
Compare
Remove redundant ipset lookups utils.NewIPSet() does this for us.
Previously with Pod egress enabled, this would get masqueraded. This change also adds cleanup for said ipset.
- Delete old/bad pod egress iptables rule(s) from old versions - When pod egress or overlay are disabled, cleanup as needed
- Avoid providing method that would delete all ipset sets on a system - New method DestroyAllWithin() destroys sets tracked by an IPSet - Create() now handles cases where Sets/System state are not in sync - Refresh() now handles leftover -temp set gracefully - Swap() now uses ipset swap - Delete() improved sync of Sets and system state - Get() now validates if map element exists before trying - etc
bzub
force-pushed
the
173-pod-to-node-nonat
branch
from
5d1197f
to
f10565a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #172
Fixes #173