route controller unit tests #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsykim
commented
Dec 28, 2017
| @@ -93,7 +95,15 @@ func StartServiceWatcher(clientset *kubernetes.Clientset, resyncPeriod time.Dura | |||
|
|
|||
| svcw.clientset = clientset | |||
| svcw.broadcaster = utils.NewBroadcaster() | |||
| lw := cache.NewListWatchFromClient(clientset.Core().RESTClient(), "services", metav1.NamespaceAll, fields.Everything()) | |||
| lw := &cache.ListWatch{ | |||
There was a problem hiding this comment.
Had to switch to this since the fake client does not have an implementation for clientset.Core().RESTClient(). It should effectively be the same thing but I have not tested it this on a real cluster.
There was a problem hiding this comment.
On a related note, I don't think we should be using global variable for the watchers, but something that can be addressed later.
andrewsykim
force-pushed
the
routes-unit-test
branch
2 times, most recently
from
060d89f
to
fa27d8f
Compare
andrewsykim
force-pushed
the
routes-unit-test
branch
from
fa27d8f
to
6cc60c7
Compare
|
Thanks @andrewsykim i have tested againest real cluster, switch from cache.NewListWatchFromClient to cache.ListWatch did not have any impact. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds unit tests for route controller.
cc @murali-reddy
#229