reverted rollingUpdate strategy #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsykim
reviewed
Feb 7, 2018
Documentation/upgrading.md
Outdated
| After updating a DaemonSet template, old DaemonSet pods will be killed, and new DaemonSet pods will be created automatically, in a controlled fashion | ||
|
|
||
| If your global BGP peers supports gracefull restarts, [rolling updates](https://kubernetes.io/docs/tasks/manage-daemon/update-daemon-set/) can be used to upgrade your kube-router DaemonSet without network downtime | ||
| To enable gracefull BGP restart kube-router must be started with `--bgp-graceful-restart` |
There was a problem hiding this comment.
I think we should add a comment that global peers also need BGP graceful restart capability enabled.
andrewsykim
reviewed
Feb 7, 2018
Documentation/upgrading.md
Outdated
| rollingUpdate: | ||
| maxUnavailable: 1 | ||
|
|
||
| maxUnavailable controlls the maximum number of pods to simultaneously upgrade |
There was a problem hiding this comment.
nit: s/controlls/controls
|
lgtm! (please squah before merging) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reverted changes to daemonsets adding rollingUpdate and documented how to do it for cluster operators