Using inclusterconfig for default configuration #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/server.go
Outdated
| var clientconfig *rest.Config | ||
| var err error | ||
| // Use out of cluster config if the URL or kubeconfig have been specified. Otherwise use incluster config. | ||
| if len(config.Master) != 0 && len(config.Kubeconfig) != 0 { |
There was a problem hiding this comment.
@dimm0 either of the --master or --kubeconfig is sufficient. so please change and condition to or.
There was a problem hiding this comment.
Ignore the travis failure. attempt to push docker image is failing for the PR's submitted from external repos. Please see #84
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using the service account credentials generated by kubernetes for accessing the api server, and auto discover the api server. If config file location is provided, it will use it as before.
Tested in kubeadm kubernetes 1.7.