Upgrade angular 13 ivy only #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: By upgrading to Angular 13, ngx-sub-form will now stop publishing view engine compatible bundle. If you're still running a pre Angular 13 version and want to use ngx-sub-form from here it should still be safe to do so thanks to ngcc. If you're on Angular 13 already then when you install the dependencies by running `npm install` or `yarn` you shouldn't see `ngx-sub-form` in the list of libraries being compiled by ngcc anymore.
maxime1992
force-pushed
the
upgrade-angular-13-ivy-only
branch
from
9b3b6d5 to
982d493
Compare
|
❌ Linting failed |
Yep, migrated to eslint but went wrong. There was loads of errors which I started to solve but it was way too long so I've turned off the new rules for now with a comment to restore them later. Hopefully it's good now! |
We should restore those later but I don't want to have to deal with this during the upgrade
maxime1992
force-pushed
the
upgrade-angular-13-ivy-only
branch
from
a31151f to
7a87fbc
Compare
|
🎉 This PR is included in version 6.0.0-feat-rewrite.17 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.