Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write namespaces into ressources (ArgoCD Helm and plain) #23

Closed
schnatterer opened this issue Jan 11, 2023 · 2 comments
Closed

Write namespaces into ressources (ArgoCD Helm and plain) #23

schnatterer opened this issue Jan 11, 2023 · 2 comments

Comments

@schnatterer
Copy link
Member

schnatterer commented Jan 11, 2023 •
edited
Loading

It would be helpful if the Helm (ArgoCDRelease) and Plain deployments would write the stage namespace into the resulting files. Or this could be activated via an option. Note: Flux (FluxV1Release) already does this!
For helm this could be realized using helm template -n.

For example the bitnami/nginx helm chart writes helm -n namespace into the k8s resources, and defaults to default. Fortunately, this can overwritten via the namespaceOverride value. But it's not intuitive and other charts might not offer an option such as this.
@schnatterer schnatterer changed the title Write namespaces into ressources Write namespaces into ressources (ArgoCD Helm and plain) Jan 11, 2023
pmarkiewka added a commit to cloudogu/gitops-playground that referenced this issue Jan 26, 2023
@pmarkiewka
We need namespaceOverride because of this bug: cloudogu/gitops-build-…
8c6bfb8 
…lib#23

cloudogu/gitops-build-lib#23

Signed-off-by: pmarkiewka <philipp.markiewka@cloudogu.com>
@schnatterer
Copy link
Member Author

This actually has been fixed years ago in 243ac51 but was only released in 0.2.0 recently

@schnatterer
Copy link
Member Author

BTW - this is not fixed for plain. But: This should not be a problem, because when the resources (e.g. a kubernetes deployment) don't specify a namespace Argo CD deploy them into the namespace specified in the Application

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@schnatterer