Add parameter to prefix namespaces #122
Conversation
We try to limit these failures by running the jar once when building the docker image. However, we run just a small part of the application. In this commit, we introduce a possibility to manually add entries to the configuration.
* Functionality to name repos, GitOps user and Jenkins Job * Name-prefix ends with '-' for Repos (TODO Namespaces, EnvVars) * Move Jenkins credentials into Job, instead of global space * Rename common to 3rd-party-dependencies * TODO write prefix into SCMM-Repo URLs and Argo CD YAML URLs and NS * TODO cluster-resources Namespaces in Deployer * TODO use prefix param in Jenkinsfile Co-authored-by: Philipp Dziosa <philipp.dziosa@cloudogu.com> Co-authored-by: Tim Siebels <tim.siebels@cloudogu.com>
As we want to replace a lot of values in those files, we think it is impractical to replace them each in code. First, it is unintuitive to find where the change is made. Secondly, we mix replacing yaml files and parsing yaml files in our code base. This approach using templating tries to solve these problems. Furthermore, we think that it improves documentation as you immediately see what would be changed in the templated file.
as groovy templating is incompatible with graal. Groovy's templating engines rely on dynamic code execution.
We decided to remove flux perspectively. Thus, we do not implement newer functionality for flux.
CloudoguSiebels
force-pushed
the
feature/naming
branch
from
9115128
to
a679141
Compare
|
I didn't do a full review, only looked at the templating feature, because I was involved in the discussions beforehand. I tried to get IDEA to understand the templating language inside the Other than that and my two comments in the code above, the templating LGTM! |
|
I am quite happy that I still get code highlighting for YAML files. In most cases the templates are valid YAML when we are only using variables and not directives. replacing |
We don't need defaults in the template directly. We can rely on the defaults via ApplicationConfigurator
We want to be more explicit that these templates are freemarker templates.
|
Tested it with prefix and reviewed code. LGTM! To mention: the technical scm user gets a name-prefix as well. |
When deploying into an existing SCM-Manager/Jenkins and/or Kubernetes cluster, we want to avoid conflicting names.
We introduce the parameter
--name-prefixwhich adds a prefix to the following:We also renamed the namespaces
argocd-stagingandargocd-productionto<prefix>-example-apps-stagingand-productionto better reflect their purpose: deploying the example apps.