Feature/all cli params via config #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
movray
force-pushed
the
feature/all-cli-params-via-config
branch
from
bdde472
to
e52b2c2
Compare
…ropertyDescription
schnatterer
force-pushed
the
feature/all-cli-params-via-config
branch
2 times, most recently
from
03adecc
to
1841f8b
Compare
schnatterer
force-pushed
the
feature/all-cli-params-via-config
branch
from
1841f8b
to
9406dfc
Compare
Remove duplicate descriptions (class and property).
Prefer properties to make it easier to see missing descriptions.
Remove dashes from descriptions to make them more fitting for config
without much effort.
Removes mail.url from ApplicationConfigurator as it seems to have been
replaced by mailhogUrl.
Replace ${COMPLETION-CANDIDATES} by static values. Unfortunately, when
adding VaultModes.values() dynamically, Groovy static compilation turns
the String into an Object, leading to failures during annotation parsing
Separate commit for easier whitespace handling in merges/conflicts.
Present in CLI, missing in Schema.groovy. Turns out: It was not used!
schnatterer
force-pushed
the
feature/all-cli-params-via-config
branch
from
9406dfc
to
b084eb7
Compare
Occurs only when a config file with specific options is passed. com.networknt.schema.JsonSchemaException: java.lang.NoSuchMethodException: com.networknt.schema.RefValidator.<init>(java.lang.String, com.fasterxml.jackson.databind.JsonNode, com.networknt.schema.JsonSchema, com.networknt.schema.ValidationContext)
schnatterer
force-pushed
the
feature/all-cli-params-via-config
branch
from
b084eb7
to
a6b75f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.