Migrate Jenkins deployment from Bash to Groovy #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the gid grepper pod will keep running unnecessarily. This implementation should also be easier to migrate to groovy later. Because it is only a single command. An alternative would have been to use kubectl wait --for=condition=complete pod/tmp-docker-gid-grepper instead of until.
This makes explicit which values need to be changed per tests and otherwise relies on defaults. This way it became obvious that b38f42d (accidentally?) introduced a change that resulted in most of the Jenkins config to be only executed when config.registry.url was set.
This also implements config.jenkins.helm.values, allow for full customization of Jenkins helm deployment
* JCasC was not necessary * sidecars.configAutoReload.enabled might reduce number of Jenkins reboots (or might not be necessary at all) * Update PATH to current agent image (jenkins/inbound-agent:3261.v9c670a_4748a_9-1 as of chart 5.5.11) * Elaborate on comments
After they moved there from ApplicationConfigurator in #241
This allows for better logging. Right now, our build on Jenkins returns empty string when grepping and cutting. This lead to the insight that pretty print of the override JSON causes the gid grepper command to return empty. 🙄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reducing the burden of our bash legacy.
This also introduces some other minor improvements
value.ftl.yaml, no more imperative helmingvalue.ftl.yamlConfig.groovyconfig.jenkins.helm.valuesallows for full customization of Jenkins helm deploymentnamespacevariables in Jenkins, ScmManager and RegistryApplication.setNamespaceListToConfig()to return redundantdefaultnamespaces 🤔 which this PR fixedApplicationConfiguratortoConfigin Typed Config for GOP #241