Fix failing apply with --remote #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roject and applications
# Conflicts: # applications/petclinic/argocd/helm/Jenkinsfile # applications/petclinic/argocd/plain-k8s/Jenkinsfile # applications/petclinic/fluxv1/helm/Jenkinsfile # applications/petclinic/fluxv1/plain-k8s/Jenkinsfile # applications/petclinic/fluxv2/plain-k8s/Jenkinsfile # scripts/apply.sh
Signed-off-by: Frederick Roy <frederick.roy@cloudogu.com>
eval true != true returned code 1, failing the build. In addition: --restart=OnFailure hides this actual error by restarting the pod and not attaching to it. This results in a timeout eventually without further logs. So it is better to just stop on failure.
Current problem: Jenkins in playground does not start due to a plugin dependency error. This leaves the build running until it is cancelled manually. A waste of resources! Currently a successful build takes less than 30 minutes. So assume more than 60 mins must be a bug.
schnatterer
force-pushed
the
feature/fix-remote-param
branch
from
0c36f26
to
a20c038
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eval true != true returned code 1, failing the build.
In addition: --restart=OnFailure hides this actual error by restarting the pod and not attaching to it. This results in a timeout eventually without further logs.
So it is better to just stop on failure.