Skip to content

Commit

Permalink
(chore): tidy up!
Browse files Browse the repository at this point in the history
  • Loading branch information
abhijith-darshan committed Feb 7, 2025
1 parent c6f23b0 commit dc45364
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions pkg/helm/helm_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ var _ = Describe("helm package test", func() {
When("getting the values for the Helm chart of a plugin", func() {
It("should correctly get regular values and overwrite helm values", func() {
plugin.Spec.OptionValues = []greenhousesapv1alpha1.PluginOptionValue{*optionValue}
helmValues, err := helm.ExportGetValuesForHelmChart(context.Background(), test.K8sClient, helmChart, plugin, true)
helmValues, err := helm.ExportGetValuesForHelmChart(context.Background(), test.K8sClient, helmChart, plugin)
Expect(err).ShouldNot(HaveOccurred(),
"there should be no error getting the values")
Expect(helmValues).ShouldNot(BeNil(),
Expand All @@ -50,7 +50,7 @@ var _ = Describe("helm package test", func() {
Expect(test.K8sClient.Create(test.Ctx, pluginSecret, &client.CreateOptions{})).
Should(Succeed(), "creating an secret should be successful")

helmValues, err := helm.ExportGetValuesForHelmChart(context.Background(), test.K8sClient, helmChart, plugin, true)
helmValues, err := helm.ExportGetValuesForHelmChart(context.Background(), test.K8sClient, helmChart, plugin)
Expect(err).ShouldNot(HaveOccurred(),
"there should be no error getting the values")
Expect(helmValues).ShouldNot(BeNil(),
Expand Down Expand Up @@ -246,7 +246,7 @@ var _ = Describe("helm package test", func() {

var _ = DescribeTable("getting helm values from Plugin", func(defaultValue any, exp any) {
helmChart := &chart.Chart{
Values: make(map[string]interface{}, 0),
Values: make(map[string]interface{}),
}

pluginWithOptionValue := &greenhousesapv1alpha1.Plugin{
Expand All @@ -265,7 +265,7 @@ var _ = DescribeTable("getting helm values from Plugin", func(defaultValue any,
},
}

helmValues, err := helm.ExportGetValuesForHelmChart(context.Background(), test.K8sClient, helmChart, pluginWithOptionValue, true)
helmValues, err := helm.ExportGetValuesForHelmChart(context.Background(), test.K8sClient, helmChart, pluginWithOptionValue)
Expect(err).ShouldNot(HaveOccurred(),
"there should be no error getting the values")
Expect(helmValues).ShouldNot(BeNil(),
Expand Down Expand Up @@ -371,7 +371,7 @@ var _ = Describe("Plugin option checksum", Ordered, func() {
Value: test.MustReturnJSONFor("pluginValue1"),
},
}
optionValuesEmpty = []greenhousesapv1alpha1.PluginOptionValue{}
optionValuesEmpty []greenhousesapv1alpha1.PluginOptionValue
)

BeforeAll(func() {
Expand Down

0 comments on commit dc45364

Please sign in to comment.