Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFAC] - Merge & Standardize DirectAccess-, and ClusterStatusController #579

Closed
4 tasks done
Tracked by #544
IvoGoman opened this issue Sep 17, 2024 · 2 comments · Fixed by #624
Closed
4 tasks done
Tracked by #544

[REFAC] - Merge & Standardize DirectAccess-, and ClusterStatusController #579

IvoGoman opened this issue Sep 17, 2024 · 2 comments · Fixed by #624
Assignees
@kengou @abhijith-darshan

Comments

@IvoGoman
Copy link
Contributor

IvoGoman commented Sep 17, 2024 •
edited
Loading

Currently there are 3 controllers which are reconciling the Cluster resource. As part of the Standardisation of the Reconciliation Loop of Greenhouse controllers these controllers should be merged into a single one.

Acceptance Criteria

  • There is one ClusterController
  • The controller can update DirectAccess clusters, but does not run the logic for HeadScaleAccess
  • The controller updates the status of the Cluster
  • HeadscaleController is not to be touched
@IvoGoman IvoGoman mentioned this issue Sep 17, 2024
Closed
9 tasks
@github-project-automation github-project-automation bot moved this to Sprint Backlog in Greenhouse Core Roadmap Sep 17, 2024
@IvoGoman IvoGoman changed the title [FEAT] - Merge & Standardize DirectAccess-, Headscale- and ClusterStatusController [REFAC] - Merge & Standardize DirectAccess-, Headscale- and ClusterStatusController Sep 17, 2024
@IvoGoman IvoGoman changed the title [REFAC] - Merge & Standardize DirectAccess-, Headscale- and ClusterStatusController [REFAC] - Merge & Standardize DirectAccess-, and ClusterStatusController Sep 20, 2024
@abhijith-darshan abhijith-darshan mentioned this issue Oct 7, 2024
Merged
26 tasks
@IvoGoman IvoGoman moved this from Sprint Backlog to In progress in Greenhouse Core Roadmap Oct 15, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Greenhouse Core Roadmap Oct 22, 2024
@abhijith-darshan
Copy link
Contributor

Update: HeadScale was removed in this PR #635

@IvoGoman
Copy link
Contributor Author

I have moved the removal of finalizers, to be tracked for all controllers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kengou kengou

@abhijith-darshan abhijith-darshan

Labels
None yet
Projects
Greenhouse Core Roadmap
Status: Done
Milestone
No milestone
3 participants
@kengou @IvoGoman @abhijith-darshan